Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Repository] refactor helm to use managed-by annotation instead of system flag #4870

Closed
dlaloue-vmware opened this issue Jun 8, 2022 · 1 comment · Fixed by #5612 or #5673
Closed

[Repository] refactor helm to use managed-by annotation instead of system flag #4870

dlaloue-vmware opened this issue Jun 8, 2022 · 1 comment · Fixed by #5612 or #5673
Assignees
@dlaloue-vmware
Labels
component/apprepository Issue related to kubeapps apprepository component/plugin-helm Issue related to kubeapps plugin to manage Helm packages kind/enhancement An issue that reports an enhancement for an implemented feature
Milestone
Update package re...

Comments

@dlaloue-vmware
Copy link
Collaborator

For repositories, secrets used for authentication can be either user managed or kubeapps managed.
The current mechanism is based on a system flag to enable one more or the other mode. This limits the flexibility to have some users use one way (e.g. cli) or the other (e.g. UI) in a single Kubeapps installation.

this issue is to refactor the helm plugin.
@dlaloue-vmware dlaloue-vmware added the kind/proposal An issue that reports a new feature proposal to be discussed label Jun 8, 2022
@antgamdia antgamdia added this to the App repository revamping milestone Jun 8, 2022
@ppbaena ppbaena added the component/apprepository Issue related to kubeapps apprepository label Jun 8, 2022
@ppbaena ppbaena added the component/plugin-helm Issue related to kubeapps plugin to manage Helm packages label Jun 20, 2022
@antgamdia antgamdia added the next-iteration Issues to be discussed in planning session label Jul 8, 2022
@antgamdia antgamdia mentioned this issue Jul 8, 2022
Closed
12 tasks
@antgamdia antgamdia mentioned this issue Jul 25, 2022
Closed
12 tasks
@ppbaena ppbaena removed the next-iteration Issues to be discussed in planning session label Oct 18, 2022
This was referenced Nov 2, 2022
Closed
Merged
dlaloue-vmware added a commit that referenced this issue Nov 17, 2022
@dlaloue-vmware
removed use of UserManagedSecrets flag for helm plugin repos (issue48…
b146e91 
…70) (#5612)

### Description of the change

refactored helm plugin to not depend on a system flag
"UserManagedSecrets" but allow secrets to be managed by user or by
kubeapps per repository

### Benefits

provides ability for different users to either choose to provide
credentials or use existing credentials on per repository basis instead
of being forced one way or another by a system flag.

### Applicable issues
- fixes #4870
@gfichtenholt
Copy link
Contributor

I don't think this should be closed. The current implementation does not use "managed-by" annotation as the title of this issue suggests, but rather relies on a hack

kubeapps/cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/repositories_auth.go

Line 669 in e5aa784

// note: for now, checking based on name pattern for backward compatibility

Implement the annotation, then close the issue, IMHO

@gfichtenholt gfichtenholt reopened this Nov 19, 2022
@dlaloue-vmware dlaloue-vmware mentioned this issue Nov 20, 2022
Merged
@ppbaena ppbaena added kind/enhancement An issue that reports an enhancement for an implemented feature and removed kind/proposal An issue that reports a new feature proposal to be discussed labels Nov 21, 2022
dlaloue-vmware added a commit that referenced this issue Nov 23, 2022
@dlaloue-vmware
issue4870 - refactor helm to use managed-by annotation (#5673)
751a5d6 
### Description of the change

The previous fix for issue 4870 did not introduce the managed-by
annotation as per the spec, but relied on naming pattern for backward
compatibility.
This presents the issue that new secrets will still depend on the old
naming pattern.

This change ensures that new or updated secrets have the managed-by
annotation, and that the code looks for this annotation.

The code stills falls back to the naming pattern for backward
compatibility, but now with a deprecation path. We can remove the naming
pattern support in a future version.

### Applicable issues

- fixes #4870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlaloue-vmware dlaloue-vmware

Labels
component/apprepository Issue related to kubeapps apprepository component/plugin-helm Issue related to kubeapps plugin to manage Helm packages kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Kubeapps
Archived in project
Milestone
Update package repository API
4 participants
@ppbaena @antgamdia @dlaloue-vmware @gfichtenholt