Allow filter rules to be set on App Repositories #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dud225
force-pushed
the
apprepository_filter
branch
from
1d83d82
to
2511705
Compare
absoludity
reviewed
Sep 21, 2021
dud225
force-pushed
the
apprepository_filter
branch
from
2511705
to
29ee23f
Compare
antgamdia
approved these changes
Sep 22, 2021
Comment on lines
+63
to
+66
| {{- if .filterRule }} | ||
| filterRule: | ||
| {{- toYaml .filterRule | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Just an internal note, it would require an increase in the patch version of the chart, but we will do when syncing with the official Bitnami repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allow filter rules to specified when creating Application Repositories from Helm.