Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filter rules to be set on App Repositories #3448

Merged
merged 2 commits into from
Sep 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions chart/kubeapps/templates/apprepository/apprepositories.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,9 @@ spec:
name: {{ printf "apprepo-%s-secrets" .name }}
{{- end }}
{{- end }}
{{- if .filterRule }}
filterRule:
{{- toYaml .filterRule | nindent 4 }}
{{- end }}
Comment on lines +63 to +66
Copy link
Contributor

@antgamdia antgamdia Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an internal note, it would require an increase in the patch version of the chart, but we will do when syncing with the official Bitnami repo.

---
{{ end -}}
8 changes: 8 additions & 0 deletions chart/kubeapps/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,14 @@ apprepository:
## ociRepositories:
## - nginx
## - jenkins
## # Optionally filter out some charts.
## # The jq query format is not exposed in the UI, so care needs to be taken to use the format which the UI expects to parse,
## # which is why variables are used in the example below.
## filterRule:
## jq: .name == $var0 or .name == $var1
## variables:
## $var0: nginx
## $var1: jenkins
##
initialRepos:
- name: bitnami
Expand Down