Update release docs and minor fixes #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Sep 23, 2021
| cd integration | ||
| # edit the Makefile with the proper version tag |
There was a problem hiding this comment.
There's also another reference to manually editing the Makefile to specify the proper tag on line 92.
docs/developer/end-to-end-tests.md
Outdated
| @@ -92,10 +92,10 @@ Our CI system relies on the [kubeapps/integration-tests](https://hub.docker.com/ | |||
| The `kubeapps/integration-tests` image is built using this [Makefile](../../integration/Makefile). Manually edit this file to specify the proper version tag. | |||
|
|
|||
| ```bash | |||
| # Get the tags from https://hub.docker.com/r/kubeapps/integration-tests | |||
There was a problem hiding this comment.
Could link directly to https://hub.docker.com/r/kubeapps/integration-tests/tags?page=1&ordering=last_updated . But more importantly, although it should be obvious, you don't mention here to "and then increment the patch version of the latest tag to get the IMAGE_TAG that you'll use below.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PRs simply performs some updates and minor fixes in the docs. It is mainly intended to cover the new kubeappsapis buf deps and code generation.
Benefits
Our docs will be updated.
Possible drawbacks
N/A
Applicable issues
Additional information
This PR doesn't fully address the aforementioned issue yet since we still have to cover how to perform the (pre) + release process