-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release docs and minor fixes #3481
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
541507c
Improve integration img build
antgamdia 3d7dbe0
Add missing imgs to docs
antgamdia 20a9d5a
Update release process
antgamdia 915747e
Add PR suggestions
antgamdia f7f8651
Merge branch 'master' into update-docs
antgamdia 8356a93
Restore unnoticed commented out line
antgamdia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,10 +92,10 @@ Our CI system relies on the [kubeapps/integration-tests](https://hub.docker.com/ | |
The `kubeapps/integration-tests` image is built using this [Makefile](../../integration/Makefile). Manually edit this file to specify the proper version tag. | ||
|
||
```bash | ||
# Get the tags from https://hub.docker.com/r/kubeapps/integration-tests | ||
cd integration | ||
# edit the Makefile with the proper version tag | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's also another reference to manually editing the Makefile to specify the proper tag on line 92. |
||
make build | ||
make push | ||
IMAGE_TAG=v1.0.1 make build | ||
IMAGE_TAG=v1.0.1 make push | ||
``` | ||
|
||
> It will build and push the image using this [Dockerfile](../../integration/Dockerfile) (we are using the base image as in the [Kubeapps Dashboard build image](../../dashboard/Dockerfile)). | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
IMAGE_TAG ?= dev | ||
|
||
default: build | ||
|
||
build: | ||
docker build -t kubeapps/integration-tests:v1.0.1 . | ||
docker build -t kubeapps/integration-tests:$(IMAGE_TAG) . | ||
|
||
push: | ||
docker push kubeapps/integration-tests:v1.0.1 | ||
# docker push kubeapps/integration-tests:$(IMAGE_TAG) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could link directly to https://hub.docker.com/r/kubeapps/integration-tests/tags?page=1&ordering=last_updated . But more importantly, although it should be obvious, you don't mention here to "and then increment the patch version of the latest tag to get the
IMAGE_TAG
that you'll use below.