Fix filtering repo tab #5400
Merged
Fix filtering repo tab #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
antgamdia
commented
Sep 27, 2022
| @@ -96,6 +96,7 @@ | |||
| "forbid": [">", "}"] // avoid warnings with single/double quotes | |||
| } | |||
| ], | |||
| "react/no-unknown-property": ["error", { "ignore": ["cds-layout"] }], // allow 'cds-layout' attribute | |||
There was a problem hiding this comment.
After upgrading the deps for a previous PR, my local env started complaining about this <div cds-layout ...> tag, so adding this eslint rule to ignore it (as it is required in Clarity).
There was a problem hiding this comment.
In fact, the PR failed because of the lack of this fix 😅 https://app.circleci.com/pipelines/github/antgamdia/kubeapps/2768/workflows/618c2248-ac94-4a19-bd3a-65323e4feb21/jobs/22024
ppbaena
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR simply fixes a wrong condition preventing the "filtering" tab from being shown.
Benefits
Tab will appear when it should.
Possible drawbacks
N/A
Applicable issues
Additional information