-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Dashboard to use new gRPC client throughout. #6044
Conversation
d61f29f
to
1b45e47
Compare
689c313
to
3e7ae06
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
57aa0d0
to
4d04cd1
Compare
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Michael Nelson <minelson@vmware.com>
type error. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
I've got the image compiling now, but haven't yet sorted out the slightly different behavior for our login checks, which is the cause of the e2e failures. |
Signed-off-by: Michael Nelson <minelson@vmware.com>
Turned out to be a simple difference in the way headers are extracted from a grpc-web response. Locally I checked everything works, including the bits that had changed (long-running requests), let's see what CI thinks. |
Signed-off-by: Michael Nelson <minelson@vmware.com>
according to the new format. Signed-off-by: Michael Nelson <minelson@vmware.com>
This is where I miss team-mates to celebrate with :P. After a lot of debugging, found what is hopefully the final CI issue - simply that the incoming error was not being converted correctly because the new grpc error does not have a |
<!-- Before you open the request please review the following guidelines and tips to help it be more easily integrated: - Describe the scope of your change - i.e. what the change does. - Describe any known limitations with your change. - Please run any tests or examples that can exercise your modified code. Thank you for contributing! --> ### Description of the change <!-- Describe the scope of your change - i.e. what the change does. --> Just a follow-up to #6044 which removes the now unused code. ### Benefits <!-- What benefits will be realized by the code change? --> ### Possible drawbacks <!-- Describe any known limitations with your change --> ### Applicable issues <!-- Enter any applicable Issues here (You can reference an issue using #) --> - ref #6013 ### Additional information <!-- If there's anything else that's important and relevant to your pull request, mention that information here.--> Signed-off-by: Michael Nelson <minelson@vmware.com>
Description of the change
This PR switches the dashboard over to use the new connect generated grpc-web client and associated generated classes.
It was pretty tedious, with some complexity due to the different generated classes and client.
Non-tedious actual changes
OneOf
concept, whereas the old improbable library just allowed all the options at once). This was quite confusing to change in the actual code functionality as the code is written as if all options may be specified, but I didn't want to change that in this PR, just switch.shared/ResourceRef
class to be a child of the generatedResourceRef
class so that we can continue to use it in place of the generated one as we're currently doing (compiler won't accept it otherwise now). CreatedResourceRef
confusion in operator support #6062 to track removing our shared one if we can.KubeappsGRPCClient
to use the new client (and the different way of setting headers/metadata).Tedious parts
new AvailablePackageSummary({...})
to pass the compilation, rather than the previous{...} as AvailablePackageSummary
as this type assertion fails due to the missing methods._pb
to import the new versions (without deleting the old in this PR, as that blows it out by 16k lines).Benefits
Let's see what CI says, but possibly removing 16k lines of the old generated code (I'll do that in a follow-up PR). The main benefit is that we'll be using a supported grpc-web typescript client and can remove the old improbable generation in the kubeapps apis service.
Possible drawbacks
It's a lot of changes, there maybe unexpected side-effects.
Applicable issues
Additional information