-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial values and container to the kubeapps-apis service. #6595
Conversation
✅ Deploy Preview for kubeapps-dev canceled.
|
1d124b8
to
09c00a0
Compare
@@ -12,7 +12,7 @@ env_logger = "0.10" | |||
futures-core = "0.3" | |||
log = "0.4" | |||
prost = "0.11" | |||
reqwest = "0.11" | |||
reqwest = { version = "0.11", default-features = false, features = ["rustls-tls"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Struggled to avoid the run-time error:
/oci-catalog/oci-catalog: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory
so the above switches off the default reqwest
feature which enables native tls and uses rustls-tls exclusively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, makes sense, latest debian distro deprecated libssl.so.1.1
in favor of a newer version, nice to see it's doable to fall back to rustls-tls. Thanks for the info!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, makes sense, latest debian distro deprecated
libssl.so.1.1
in favor of a newer version
Yeah, but I even tried compiling with rust:1.71.1-bookworm
, which compiled fine (so I assume should have been linking to libssl3), but it would have the same runtime error (tested in that same build image just running binary with -h
, rather than transferring to the output image). But yes, glad we can use rusttls instead.
8e6b604
to
955ebfb
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Update oci-catalog to not depend on native-tls. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
955ebfb
to
f928705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, but I'd have to double-check #6605 (comment). I don't know if here we are also adding duplicated keys to the yaml. Anyway, +1 to merge it now and fix it later (if so).
Signed-off-by: Michael Nelson <minelson@vmware.com>
Done - thanks. |
…6618) ### Description of the change Follows on from #6595, updates the proto service files according to buf's lint, and generates the go client for use in the asset-syncer. Note: I added a separate `buf.yaml` and `buf.gen.yaml` for the oci-catalog service as buf doesn't let you refer to a proto outside of the `buf.yaml` root, so the other option would have been to move our existing `buf.yaml` and `buf.generate` into the Kubeapps root directory. I don't mind either way, but it made more sense to me for the oci-catalog service to have its own so that it is independent (it may be useful outside of Kubeapps, theoretically). ### Benefits The next PR can use the client without being cluttered by the extra diff. ### Applicable issues <!-- Enter any applicable Issues here (You can reference an issue using #) --> - ref: #6263 --------- Signed-off-by: Michael Nelson <minelson@vmware.com>
Description of the change
Adds the initial values and container for the oci-catalog to the kubeapps-apis service.
Leaving in draft for the moment as there are a number of things I want to check IRL while playing:
Use an actual grpc liveness check (to test that out, since we can remove the grpc health binary, as our oldest k8s version is now past 1.24)Bitnami tests are still testing with 1.23 apparently.Note: I've got
ociCatalog.enabled
defaulting to false now, so no change to the chart output.Benefits
Can start integration.
Possible drawbacks
Applicable issues
Additional Information
With these changes in dev: