Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds generated go client for oci-catalog that we'll use from syncer. #6618

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

absoludity
Copy link
Contributor

Description of the change

Follows on from #6595, updates the proto service files according to buf's lint, and generates the go client for use in the asset-syncer.

Note: I added a separate buf.yaml and buf.gen.yaml for the oci-catalog service as buf doesn't let you refer to a proto outside of the buf.yaml root, so the other option would have been to move our existing buf.yaml and buf.generate into the Kubeapps root directory. I don't mind either way, but it made more sense to me for the oci-catalog service to have its own so that it is independent (it may be useful outside of Kubeapps, theoretically).

Benefits

The next PR can use the client without being cluttered by the extra diff.

Applicable issues

Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the independent buf.yaml files. However, I would add this to the release docs (under the Protobuf dependencies and autogenerated code section), mainly just not to forget about this component when upgrading our deps.

Base automatically changed from add-oci-catalog-to-deploy to main August 15, 2023 01:21
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity force-pushed the 6263-use-oci-catalog-validation branch from 8b66cff to 3bc6fe0 Compare August 15, 2023 01:24
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit e7f6d04
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64dad74aa68d720008974afb

@absoludity
Copy link
Contributor Author

+1 to the independent buf.yaml files. However, I would add this to the release docs (under the Protobuf dependencies and autogenerated code section), mainly just not to forget about this component when upgrading our deps.

Thanks. I added two small makefile targets to handle both projects for us and updated the release docs to use that.

Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity merged commit aab5a8c into main Aug 15, 2023
40 checks passed
@absoludity absoludity deleted the 6263-use-oci-catalog-validation branch August 15, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants