Implement tests for the VCH Creation API [specific ci=Group23-Vic-Machine-Service] #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
2 times, most recently
from
bf0b75b
to
b277ec4
Compare
zjs
force-pushed
the
feature/vic-machine-service
branch
from
9f9e9b9
to
741f5ea
Compare
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
from
5fc84e6
to
cdd6d7c
Compare
This was referenced Oct 20, 2017
Merged
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
2 times, most recently
from
d416617
to
63191f7
Compare
zjs
force-pushed
the
feature/vic-machine-service
branch
from
f7667f3
to
4cc1a61
Compare
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
3 times, most recently
from
77c0e03
to
be08f85
Compare
zjs
changed the title
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
from
be08f85
to
fad93c5
Compare
mdharamadas1
approved these changes
Oct 25, 2017
|
|
||
| *** Test Cases *** | ||
| Create minimal VCH | ||
| ${before}= Count VCHs |
There was a problem hiding this comment.
I'm not sure if counting number of VCHs is required here but it may create issue when we have these tests running concurrently. Just FYI.
There was a problem hiding this comment.
Good point. I'll remove the counting; I think being able to inspect it is sufficient proof that the VCH was properly created.
AngieCris
reviewed
Oct 25, 2017
I added verification for the information I could find in |
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
from
33d7013
to
2c23714
Compare
jzt
approved these changes
Oct 26, 2017
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
from
2c23714
to
5f837d9
Compare
AngieCris
approved these changes
Oct 26, 2017
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
from
5f837d9
to
53e8a7b
Compare
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
3 times, most recently
from
62d6ae1
to
1567845
Compare
zjs
force-pushed
the
topic/vic-machine-service-robot-create
branch
from
1567845
to
2faf0a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a suite of positive and negative tests for API-based VCH creation. These tests are not intended to be exhaustive; we can use unit tests for that.
Note that these tests only verify the resulting VCHs using
inspectand do not verify their functionality using docker. That would be desirable validation, but the existingRun Regression Testskeyword (and related code) isn't currently written in a way that allows it to be used by these tests. Exposing theRun Regression Testsfunctionality in a way that more clearly captures the expected set of inputs would be a good first step towards being able to re-use it in this manner.