Properly extract CPU speed in VCH creation handler #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because JSON and Go have different models for inheritance, properly interpreting the structure of the API parameters can be confusing. In this case, we need to reference the nested units variable from the "subclass" instead of the units variable in the parent, which will always have its zero value (the empty string).
zjs
added
area/api
AngieCris
approved these changes
Oct 24, 2017
andrewtchin
approved these changes
Oct 24, 2017
jzt
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because JSON and Go have different models for inheritance, properly interpreting the structure of the API parameters can be confusing.
In this case, we need to reference the nested units variable from the "subclass" instead of the units variable in the parent, which will always have its zero value (the empty string).
Note that this was discovered while working on #6019 and will be tested as a part of #6527.