Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TV logo with voctocat #224

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Replace TV logo with voctocat #224

merged 1 commit into from
Mar 6, 2017

Conversation

blinry
Copy link
Contributor

@blinry blinry commented Mar 1, 2017

See #215.

screenshot-2017-03-01_15 54 59

This replaces:

  • the favicons, and the apple-touch-icons
  • the logo in the header
  • the play/pause button ("bigplay") displayed in the center of the mediaplayer when the video is paused

I couldn't figure out what /vendor/assets/mediaelement/bigplay.fw.png is used for, and how it should differ from the non-"fw" PNG. Can @manno help explain?

@rohieb
Copy link

rohieb commented Mar 1, 2017

Hmm, these images look blurry to me:

  • public/apple-touch-icon-precomposed.png
  • public/apple-touch-icon.png
  • public/apple-touch-icon-76x76.png

@blinry
Copy link
Contributor Author

blinry commented Mar 1, 2017

Good catch, @rohieb! I forgot to specify the density when using ImageMagick to convert these. Should be as crisp as those resolutions allow now, I force-updated the branch.

@rohieb
Copy link

rohieb commented Mar 1, 2017

@blinry yes, it seems for PRs with several pictures it's probably best to look at them again on the GitHub web view ^^

@MaZderMind
Copy link
Contributor

That looks really Awsome <3

@MaZderMind MaZderMind merged commit 05301d6 into voc:master Mar 6, 2017
@blinry
Copy link
Contributor Author

blinry commented Mar 6, 2017

I'm glad you like it! :)

Hm, @manno, could you explain how /vendor/assets/mediaelement/bigplay.fw.png and /vendor/assets/mediaelement/bigplay.png should be different? (They're the same, currently.)

@blinry
Copy link
Contributor Author

blinry commented Mar 6, 2017

@MaZderMind, if you want to, you can link to https://morr.cc/voctocat/ in the news entry – the SVG & license is there, just in case someone wants to reuse it! :)

@MaZderMind
Copy link
Contributor

@blinry gute idee, hab ich geändert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants