Improve skeletons #124
Merged
Improve skeletons #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selankon
force-pushed
the
f/improve-skeletons
branch
from
fa0f139
to
5e043c0
Compare
|
I don't see most of the cases fixed, the issues remain |
Sorry I set it "ready for review" by mistake |
selankon
force-pushed
the
f/improve-skeletons
branch
from
5e043c0
to
fe9974b
Compare
selankon
force-pushed
the
f/improve-skeletons
branch
from
fe9974b
to
2796c77
Compare
selankon
force-pushed
the
f/improve-skeletons
branch
from
2796c77
to
e584d34
Compare
selankon
force-pushed
the
f/improve-skeletons
branch
from
025c028
to
e769166
Compare
elboletaire
approved these changes
Sep 5, 2024
elboletaire
added a commit
that referenced
this pull request
Sep 9, 2024
* Review process pagination (#123) * Fix block txCount (#103) * Improve skeletons (#124) * Add gap to transaction list * Implement async list layout * Implement AsyncListLayout on all lists * Refactor to extract logic * Implement fees table isLoading * Memoize components * Implement async table * Implement envelope loading * Add txCount to tab * Implement PaginatedAsyncList on account elections * Use txCount * Bump vocdoni packages (#125) * Bump vocdoni packages * Fix deprecated api methods * Fix new types * Fix tx subtype * Fix tx_title * Fix tx card layout * Fix tx card layout * chakra-components pagination (#126) * Refactor adding chakra-components pagination components (and other fixes) * Upgrade chakra-components version * Revert "chakra-components pagination (#126)" This reverts commit 7a6101a. * Pagination via components (this time is true) (#127) * Refactor adding chakra-components pagination components (and other fixes) * Upgrade chakra-components version * Update packages fixing dependency error * Update packages fixing missing exports * Eat this, node * Fix latest blocks loading skeleton (#128) * Force light theme to avoid issues (specially for devs) --------- Co-authored-by: selankon <selankon@selankon.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
Fixes #95