Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination via components (recovery after revert) #127

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

elboletaire
Copy link
Member

I've reverted the PR #126 since it crashes the entire application. I think it's a bad chakra-components build, but I'm out of time this week, so I've reverted the changes and open this PR again. Next week I'll take a look.

Copy link

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 15:23 Inactive
Copy link

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 15:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 08:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 08:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 09:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 09:53 Inactive
@elboletaire elboletaire merged commit 54695a6 into main Sep 9, 2024
3 checks passed
@elboletaire elboletaire deleted the f/pagination-via-components branch September 9, 2024 09:55
elboletaire added a commit that referenced this pull request Sep 9, 2024
* Review process pagination (#123)

* Fix block txCount (#103)

* Improve skeletons (#124)

* Add gap to transaction list

* Implement async list layout

* Implement AsyncListLayout on all lists

* Refactor to extract logic

* Implement fees table isLoading

* Memoize components

* Implement async table

* Implement envelope loading

* Add txCount to tab

* Implement PaginatedAsyncList on account elections

* Use txCount

* Bump vocdoni packages (#125)

* Bump vocdoni packages

* Fix deprecated api methods

* Fix new types

* Fix tx subtype

* Fix tx_title

* Fix tx card layout

* Fix tx card layout

* chakra-components pagination (#126)

* Refactor adding chakra-components pagination components (and other fixes)
* Upgrade chakra-components version

* Revert "chakra-components pagination (#126)"

This reverts commit 7a6101a.

* Pagination via components (this time is true) (#127)

* Refactor adding chakra-components pagination components (and other fixes)

* Upgrade chakra-components version

* Update packages fixing dependency error

* Update packages fixing missing exports

* Eat this, node

* Fix latest blocks loading skeleton (#128)

* Force light theme to avoid issues (specially for devs)

---------

Co-authored-by: selankon <selankon@selankon.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant