Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gui): configurable output file name #453

Merged
merged 1 commit into from
Apr 23, 2023
Merged

feat(gui): configurable output file name #453

merged 1 commit into from
Apr 23, 2023

Conversation

alexanderkoumis
Copy link
Contributor

@alexanderkoumis alexanderkoumis commented Apr 22, 2023 •
edited
Loading

Closes #452

Implements:

  • Output file box
  • Auto incrementing default output path

Screenshot 2023-04-22 170051

@alexanderkoumis alexanderkoumis force-pushed the output_file branch 2 times, most recently from fd26bec to d93aea7 Compare April 22, 2023 03:59
34j
34j requested changes Apr 22, 2023
View reviewed changes
src/so_vits_svc_fork/gui.py Outdated Show resolved Hide resolved
@34j
Copy link
Collaborator

34j commented Apr 22, 2023 •
edited
Loading

Thanks for your contribution.

@34j 34j changed the title feat(gui): configurable output file (#452) feat(gui): configurable output file name Apr 22, 2023
@alexanderkoumis alexanderkoumis force-pushed the output_file branch 4 times, most recently from a714be1 to 66562e7 Compare April 22, 2023 23:46
34j
34j requested changes Apr 23, 2023
View reviewed changes
src/so_vits_svc_fork/gui.py Outdated Show resolved Hide resolved
@34j 34j self-requested a review April 23, 2023 10:46
@34j 34j merged commit d2e3596 into voicepaw:main Apr 23, 2023
@34j
Copy link
Collaborator

34j commented Apr 23, 2023

@allcontributors add alexanderkoumis code

@allcontributors allcontributors bot mentioned this pull request Apr 23, 2023
Merged
@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @alexanderkoumis! 🎉

@34j
Copy link
Collaborator

34j commented Apr 25, 2023

@alexanderkoumis
It seems that some people find this change not very convenient. If you don't mind, can you elaborate it further? (#492)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@34j 34j 34j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable output file
3 participants
@alexanderkoumis @34j @visidyn