Skip to content

Commit

Permalink
Do not clean up resources after execution
Browse files Browse the repository at this point in the history
Revert #969

This should never have been merged. The client still needs the kernel
and channels running after execution !

Co-authored-by: davidbrochart <davidbrochart@users.noreply.github.com>
  • Loading branch information
martinRenou and davidbrochart committed Jun 23, 2023
1 parent f416ab5 commit 0c04024
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions voila/notebook_renderer.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,6 @@ async def _jinja_notebook_execute(self, nb, kernel_id):
# (it seems to be local to our block)
nb.cells = result.cells

await self._cleanup_resources()

async def _jinja_cell_generator(self, nb, kernel_id):
"""Generator that will execute a single notebook cell at a time"""
nb, _ = ClearOutputPreprocessor().preprocess(
Expand Down Expand Up @@ -295,12 +293,6 @@ async def _jinja_cell_generator(self, nb, kernel_id):
finally:
yield output_cell

await self._cleanup_resources()

async def _cleanup_resources(self):
await ensure_async(self.executor.km.cleanup_resources())
await ensure_async(self.executor.kc.stop_channels())

async def load_notebook(self, path):
model = await ensure_async(self.contents_manager.get(path=path))
if "content" not in model:
Expand Down

0 comments on commit 0c04024

Please sign in to comment.