Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add events and actions for task reschedule #140

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

bibibox
Copy link
Contributor

@bibibox bibibox commented Nov 11, 2024

prepare for the volcano issue volcano-sh/volcano#3812

Signed-off-by: WenBo Zhang <407871927@qq.com>
@volcano-sh-bot
Copy link
Collaborator

Welcome @bibibox!

It looks like this is your first PR to volcano-sh/apis.

Thank you, and welcome to Volcano. 😃

@william-wang william-wang changed the title add events and actions for task deschedule add events and actions for task reschedule Nov 12, 2024
PodPendingEvent Event = "PodPending"

// PodRunningEvent is triggered if Pod was running
PodRunningEvent Event = "PodRunning"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intention for PodRunning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the pod corresponding to a podFailed/podEvicted event returns to the running state, its delayed action should be canceled. So we need to be able to detect the pod running event.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense:)

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit f278b63 into volcano-sh:master Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants