[WIP] support more actions for volcano job failure scenario #3813
Conversation
volcano-sh-bot
added
the
size/XL
bibibox
force-pushed
the
add_job_policy_timeout
branch
from
8206c69 to
dfb4a4f
Compare
bibibox
changed the title
volcano-sh-bot
added
the
do-not-merge/work-in-progress
bibibox
force-pushed
the
add_job_policy_timeout
branch
from
dfb4a4f to
fc3fa27
Compare
| for podName, delayAct := range taskMap { | ||
| shouldCancel := false | ||
|
|
||
| if podName == req.PodName { |
There was a problem hiding this comment.
why use for key := range taskMap if key == xxx rather than val, exists := taskMap[key]?
| } | ||
| } | ||
| } | ||
| cc.delayActionMapLock.Unlock() |
There was a problem hiding this comment.
refactor into a function and unlock by defer
| req.Namespace, req.JobName, err) | ||
| } | ||
|
|
||
| func (cc *jobcontroller) cleanupDelayActions(jobKey string, excludePod string) { |
There was a problem hiding this comment.
The parameter excludePod can be misunderstood. Literally, it suggests "cleanup actions exclude this pod," but in reality, it merely skips the execution of the CancelFunc.
Additionally, the CancelFunc can be executed multiple times. So it is unnecessary to check it.
bibibox
force-pushed
the
add_job_policy_timeout
branch
from
fc3fa27 to
b45b6c4
Compare
Signed-off-by: Box Zhang <wszwbsddbk@gmail.com>
bibibox
force-pushed
the
add_job_policy_timeout
branch
from
b45b6c4 to
a09a6bb
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
needs-rebase
|
@bibibox: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Implement issue #3812
fix failed ci pipeline after the related pr at apis repo volcano-sh/apis#140 merged