Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Only generate required scheduler configmap #396

Merged
merged 1 commit into from
Aug 19, 2019
Merged

[cleanup] Only generate required scheduler configmap #396

merged 1 commit into from
Aug 19, 2019

Conversation

TommyLike
Copy link
Contributor

For #367

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2019
@TommyLike TommyLike force-pushed the cleanup/charts branch 2 times, most recently from e38b3dd to f63ea62 Compare July 30, 2019 03:12
@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fa8519b0-b277-11e9-820a-1b236510c586

@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2afa30d0-b278-11e9-820a-1b236510c586

@hzxuzhonghu
Copy link
Collaborator

/lgtm

@TommyLike
Copy link
Contributor Author

/assign @k82cn

@k82cn
Copy link
Member

k82cn commented Aug 19, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@volcano-sh-bot volcano-sh-bot merged commit 7ba297f into volcano-sh:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TommyLike @TravisBuddy @hzxuzhonghu @k82cn @volcano-sh-bot