Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Only generate required scheduler configmap #396

Merged
merged 1 commit into from
Aug 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion hack/generate-yaml.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ fi
cat ${VK_ROOT}/installer/namespace.yaml > ${DEPLOYMENT_FILE}
${HELM_BIN_DIR}/helm template ${VK_ROOT}/installer/helm/chart/volcano --namespace volcano-system \
--name volcano --set basic.image_tag_version=${VOLCANO_IMAGE_TAG} \
--set basic.scheduler_config_file=volcano-scheduler.conf \
-x templates/admission.yaml \
-x templates/batch_v1alpha1_job.yaml \
-x templates/bus_v1alpha1_command.yaml \
Expand Down
2 changes: 1 addition & 1 deletion hack/run-e2e-kind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function install-volcano {
kind load docker-image ${MPI_EXAMPLE_IMAGE} ${CLUSTER_CONTEXT}

echo "Install volcano chart"
helm install installer/helm/chart/volcano --namespace kube-system --name ${CLUSTER_NAME} --kubeconfig ${KUBECONFIG} --set basic.image_tag_version=${TAG} --set basic.scheduler_config_file=volcano-scheduler-ci.conf --wait
helm install installer/helm/chart/volcano --namespace kube-system --name ${CLUSTER_NAME} --kubeconfig ${KUBECONFIG} --set basic.image_tag_version=${TAG} --set basic.scheduler_config_file=config/volcano-scheduler-ci.conf --wait
}

function uninstall-volcano {
Expand Down
2 changes: 1 addition & 1 deletion installer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ The following are the list configurable parameters of Volcano Chart and their de
|`basic.scheduler_image_name`|Scheduler Docker Image Name|`volcanosh/vc-scheduler`|
|`basic.admission_image_name`|Admission Controller Image Name|`volcanosh/vc-admission`|
|`basic.admission_secret_name`|Volcano Admission Secret Name|`volcano-admission-secret`|
|`basic.scheduler_config_file`|Configuration File name for Scheduler|`volcano-scheduler.conf`|
|`basic.scheduler_config_file`|Configuration File name for Scheduler|`config/volcano-scheduler.conf`|
|`basic.image_pull_secret`|Image Pull Secret|`""`|
|`basic.image_pull_policy`|Image Pull Policy|`IfNotPresent`|
|`basic.admission_app_name`|Admission Controller App Name|`volcano-admission`|
Expand Down
4 changes: 2 additions & 2 deletions installer/helm/chart/volcano/templates/scheduler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: {{ .Release.Name }}-scheduler-configmap
namespace: {{ .Release.Namespace }}
data:
{{- (.Files.Glob "config/*").AsConfig | nindent 2 }}
{{- (.Files.Glob .Values.basic.scheduler_config_file).AsConfig | nindent 2 }}
---
apiVersion: v1
kind: ServiceAccount
Expand Down Expand Up @@ -110,7 +110,7 @@ spec:
image: {{.Values.basic.scheduler_image_name}}:{{.Values.basic.image_tag_version}}
args:
- --alsologtostderr
- --scheduler-conf=/volcano.scheduler/{{.Values.basic.scheduler_config_file}}
- --scheduler-conf=/volcano.scheduler/{{base .Values.basic.scheduler_config_file}}
- -v=3
- 2>&1
imagePullPolicy: "IfNotPresent"
Expand Down
2 changes: 1 addition & 1 deletion installer/helm/chart/volcano/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ basic:
scheduler_image_name: "volcanosh/vc-scheduler"
admission_image_name: "volcanosh/vc-admission"
admission_secret_name: "volcano-admission-secret"
scheduler_config_file: "volcano-scheduler.conf"
scheduler_config_file: "config/volcano-scheduler.conf"
image_pull_secret: ""
13 changes: 0 additions & 13 deletions installer/volcano-development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,6 @@ metadata:
name: volcano-scheduler-configmap
namespace: volcano-system
data:
volcano-scheduler-ci.conf: |
actions: "enqueue, reclaim, allocate, backfill, preempt"
tiers:
- plugins:
- name: priority
- name: gang
- name: conformance
- plugins:
- name: drf
- name: predicates
- name: proportion
- name: nodeorder
- name: binpack
volcano-scheduler.conf: |
actions: "enqueue, allocate, backfill"
tiers:
Expand Down