-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change node not found errors #584
Conversation
Travis tests have failedHey @davidstack, TravisBuddy Request Identifier: e1301f10-1630-11ea-81b2-273600e26419 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidstack, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
change three commits to one commit |
/lgtm |
thanks very much for the contribution! |
Hey @davidstack, TravisBuddy Request Identifier: 47b4eac0-1638-11ea-81b2-273600e26419 |
Hey @davidstack, TravisBuddy Request Identifier: 3e2301d0-1639-11ea-81b2-273600e26419 |
bugreport:
after remove one node from k8s cluster, when schedule new pod use kube-batch/volcano ,pod may be failed to scheule with this error
the GetNodeInfo in file /pkg/scheduler/plugins/util/util.go and pkg/scheduler/plugins/nodeorder/noderorder.go shoud change node not found errors to kubernetes's node not found error,like this
errors.NewNotFound(v1.Resource("node"), name)
this function is called by k8s code (InterPodAffinityMatches function )when check pod Affinity.
in k8s function getMatchingAntiAffinityTopologyPairsOfPods,it will ignore node that not exist.