Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change node not found errors #584

Merged
merged 1 commit into from
Dec 4, 2019
Merged

change node not found errors #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/scheduler/plugins/nodeorder/nodeorder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License.
package nodeorder

import (
"fmt"
"k8s.io/apimachinery/pkg/api/errors"

v1 "k8s.io/api/core/v1"
"k8s.io/klog"
Expand Down Expand Up @@ -237,7 +237,7 @@ func (c *cachedNodeInfo) GetNodeInfo(name string) (*v1.Node, error) {
}
}
}
return nil, fmt.Errorf("failed to find node <%s>", name)
return nil, errors.NewNotFound(v1.Resource("node"), name)
}

return node.Node, nil
Expand Down
5 changes: 3 additions & 2 deletions pkg/scheduler/plugins/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License.
package util

import (
"fmt"
"k8s.io/apimachinery/pkg/api/errors"

v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/labels"
Expand Down Expand Up @@ -204,7 +204,8 @@ type CachedNodeInfo struct {
func (c *CachedNodeInfo) GetNodeInfo(name string) (*v1.Node, error) {
node, found := c.Session.Nodes[name]
if !found {
return nil, fmt.Errorf("failed to find node <%s>", name)

return nil, errors.NewNotFound(v1.Resource("node"), name)
}

return node.Node, nil
Expand Down