Validate ACLs against rd-acl recommendations

[jyaworski]

Validates against RD 2.6's rd-acl validate.

@liamjbennett

[igalic]

@jyaworski can you briefly explain what this code does?
perhaps amend the commit message too ;)

[jyaworski]

@igalic done.

So Rundeck 2.6 introduced 'rd-acl validate' to lint and validate aclpolicy files. This changes the template to conform to those linting recommendations.

What this does, essentially, is adds a hyphen only to every other line (a rule is considered an action and allow/deny statement).

[jyaworski]

I'll admit that this isn't a good solution, as every-other line is only the most common way of specifying ACLs. A better way would have the ACLs grouped in a hash somehow, but that's a breaking change.

http://rundeck.org/2.6.0/man5/aclpolicy.html#type-rules

[jyaworski]

Hold off on merging this. I'm going to refactor it.

[jyaworski]

OK, now it's good to merge. I was overthinking it in my last few comments. It was already an array of hashes; no compatibility break.

[igalic]

@jyaworski can we introduce a test for this?

[jyaworski]

@igalic the validate_acl function is kind of like a test for this already. Were you meaning something else?

[igalic]

what i meant is actual spec tests, such as https://github.com/puppet-community/puppet-rundeck/blob/master/spec/functions/validate_rd_policy/signature_spec.rb and https://github.com/puppet-community/puppet-rundeck/blob/master/spec/defines/config/resource_source_spec.rb

[jyaworski]

I'm holding on this until #134 gets merged.

[jyaworski]

Okay. This is good to be merged.

[nibalizer]

@jyaworski can you squash?

[jyaworski]

I rebased down into one commit; did you mean something else?

[nibalizer]

Thanks!