Update from puppet-community modulesync_configs #134
Conversation
|
I think this is failing because the tests are missing the :puppetversion fact. You should be able to rebase on master to fix this. |
|
I rebased; it looks like it's more fundamental than that. |
|
Rubocop stuff, after merging @igalic's work. I'll work on this sometime next week likely. |
|
i suggest you start with (a couple of iterations of) |
|
Having just run this and seen how much work is involved in cleaning up my bad code. I just wanted to jump on this ticket and thank you @jyaworski for doing the hard work here. |
|
💜 y'all! |
|
as i've mentioned elsewhere, i'm not entirely happy with some of the formatting here… |
|
This is almost ready, with a lot of changes. We're still discussing on modulesync_config about rubocop, which is what's failing now. |
|
OK, this is finally ready. Once this is merged I'll look into adding the module to modulesync_config's managed_modules. |
| module Parser | ||
| # Functions | ||
| module Functions | ||
| newfunction(:validate_rd_policy, :doc => <<-'ENDHEREDOC') do |args| |
There was a problem hiding this comment.
aeehmpf.. please don't do this :O
what you actually should be doing is:
Puppet::Parser::Functions.newfunction(:validate_rd_policy,…thereby wholy removing one indentation level, rather than introducing three ;)
|
@jyaworski thank you so so much for making this effort |
|
I followed a bit of your suggestions, with pgrep and module nesting. Do I need to do any more work here, or is this good to finally merge? |
|
It looks like I had to install a few gems. It works locally, but fails on travis. Let me open another issue... |
|
All right! Good to go, finally. @igalic and @liamjbennett |
Update from puppet-community modulesync_configs
|
/me breaks everything yayyyy |
#133 changes
Tag @liamjbennett.
(If you're at Puppetconf, I'm by @igalic)