Add class to manage security-role in web.xml #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It took me a while to figure out why I couldn't log into Rundeck at first, and got burned by this. Is there a chance of this getting merged? |
| @@ -106,6 +106,9 @@ A hash of the notification email configuraton. | |||
| #####`security_config` | |||
| A hash of the rundeck security configuration. | |||
|
|
|||
| #####`security_role` | |||
There was a problem hiding this comment.
i read this as security_hole…
|
@wcooley could you please rebase this against the current master? @jyaworski if @wcooley has no time, or doesn't respond, maybe you could take over? |
wcooley
force-pushed
the
wcooley/feature-security-role-webxml
branch
from
13c3afb
to
07616f8
Compare
|
There you go -- it's rebased onto master now. |
igalic
added a commit
that referenced
this pull request
Oct 14, 2015
Add class to manage security-role in web.xml
|
thank you so much @wcooley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To change the
security-rolecurrently one must editweb.xmldirectly, and reapply the change upon upgrade, as that file is version-specific and must be kept in sync with the application. I have opened an issue with rundeck to make that configurable via something in/etc/rundeck(rundeck/rundeck#1261), but unless or until that is resolved, I need to be able to manage it.This creates a
rundeck::config::global::webclass with this as the sole parameter which is also added and passed throughrundeckandrundeck::config. I chose to use an augeas resource because the file is XML and needs to be replaced outside of Puppet, so a template would not work. Many people have an aversion to augeas because it can get complicated; I find that for certain classes of problems it can be fairly easy. The only hitch is that testing augeas commands is non-trivial (requires rspec-puppet-augeas which was broken for a while due to rspec-puppet).I would also like to be able to set the
session-timeoutinweb.xmlso if this approach is acceptable I will add that to the...::webclass.