Disable snmpv2 #128
Disable snmpv2 #128
Conversation
|
Hi, Regards |
|
Hello @razorsedge can you help me to fix the travis error ? |
| @@ -353,6 +358,7 @@ | |||
| $agentx_socket = $snmp::params::agentx_socket, | |||
| $agentx_timeout = $snmp::params::agentx_timeout, | |||
| $agentx_retries = $snmp::params::agentx_retries, | |||
| $snmpv2_enable = $snmp::params::snmpv2_enable, | |||
There was a problem hiding this comment.
Can you please add a datatype to this?
| @@ -362,6 +368,7 @@ | |||
| validate_bool($service_hasstatus) | |||
| validate_bool($service_hasrestart) | |||
| validate_bool($openmanage_enable) | |||
| validate_bool($snmpv2_enable) | |||
There was a problem hiding this comment.
please do not add the legacy validate_* methods. Datatypes are the new way to go \o/
| @@ -404,6 +404,13 @@ | |||
| $safe_trap_service_hasrestart = $trap_service_hasrestart | |||
| } | |||
|
|
|||
| $snmp_snmpv2_enable = getvar('::snmpv2_enable') | |||
There was a problem hiding this comment.
why do you use getvar() here? And should it default to false? Since SNMPv2 isn't considered to be secure and the next release will be a major one, so we can introduce breaking changes.
|
Hi @hdep, this module was recently migrated to Vox Pupuli. Please rebase against our latest master branch. Can you please take a look at the inline comments I made and add a test for your change? |
|
Do you want a new PR with the changes ? |
|
sorry, I closed it by accident! But let's continue in the new PR. |
|
no problem ! |
Hello,
Here is a small PR which create a new variable snmpv2_enable, by default this variable is at true, so there is no change from current behaviour.
If set to false, this remove com2sec, group, and access config in snmpd.conf and there is no error in the log when restarting the daemon.