Add $snmpv2_enable parameter #136
Conversation
|
Can you please rebase against our latest master? Your branch isn't up2date. Let me know if you need some help with git. You can reach us in #voxpupuli on freenode or on https://puppetcommunity.slack.com. |
manifests/init.pp
Outdated
| @@ -353,6 +358,9 @@ | |||
| $agentx_socket = $snmp::params::agentx_socket, | |||
| $agentx_timeout = $snmp::params::agentx_timeout, | |||
| $agentx_retries = $snmp::params::agentx_retries, | |||
|
|
|||
| Boolean $snmpv2_enable = $snmp::params::snmpv2_enable, | |||
There was a problem hiding this comment.
can you align the = with the others please?
manifests/params.pp
Outdated
| @@ -404,6 +404,12 @@ | |||
| $safe_trap_service_hasrestart = $trap_service_hasrestart | |||
| } | |||
|
|
|||
| if $snmp_openmanage_enable { | |||
| $snmpv2_enable = $::snmp_snmpv2_enable | |||
There was a problem hiding this comment.
where is $snmp_snmpv2_enable coming from? Shouldn't we just do:
$snmpv2_enable = false
?
There was a problem hiding this comment.
I think you are right; This parameter come from init.pp and default value is in params.pp. I'll fix this.
|
@hdep can you take a look at the failing tests? |
|
I guess default '$snmpv2_enable = false' broke the rspec test. I'll give a try with default to true. |
spec/classes/snmp_init_spec.rb
Outdated
| @@ -1282,4 +1282,41 @@ | |||
| end | |||
| end | |||
| end | |||
| context 'on a supported osfamily (Suse), with snmpv2_enable = true' do | |||
There was a problem hiding this comment.
can you please use rspec-puppet-facts here?
|
here it is. Currently '$snmpv2_enable = true'. If the rpsec is fine for you I can try to change the value to false. |
|
Thanks for the work @hdep! I squashed the commits and will merge it after travis is green. |
|
Thank you for your help. Currently default will enable snmpv2, maybe later we can check to switch it to false later. |
Same PR as #128 with fixes as requested.