Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict variable checking #85

Closed
wants to merge 1 commit into from
Closed

Strict variable checking #85

wants to merge 1 commit into from

Conversation

cdenneen
Copy link

Fixes issues with strict variable checks failing

@cdenneen
Copy link
Author

@razorsedge So in order to get this to work the json gem would have to be turned into JSON_GEM_VERSION environment variable because ruby <2.0 requires json < 2.0
I know you use modulesync so I didn't want to break that.

@razorsedge razorsedge self-assigned this Apr 3, 2017
@razorsedge razorsedge added the enhancement New feature or request label Apr 3, 2017
@coreone coreone mentioned this pull request May 13, 2017
Merged
razorsedge added a commit that referenced this pull request May 20, 2017
@razorsedge
Update rspec tests to pass strict variables fix.
af66275 
Closes GH-21, GH-65, GH-85, GH-97, and GH-103.
@razorsedge
Copy link
Contributor

Closed by #102

@razorsedge razorsedge closed this May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@razorsedge razorsedge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdenneen @razorsedge