GetBytesWithMime を VRMShaders に移動 #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* UniGLTF.GltfTextureExporter.GetBytesWithMime を VRMShaders.AssetTextureUtil.GetTextureBytesWithMime に移動 * テスト NotReadable, Compressed を VRMShaders に移動 * テスト用リソース Resources/4x4.png と 4x4compressed.DDS を VRMShaders に移動
ousttrue
force-pushed
the
fix/do_not_use_resources
branch
from
1b17158 to
e35bc5f
Compare
Santarh
approved these changes
Apr 12, 2021
| /// <returns></returns> | ||
| public static (byte[] bytes, string mine) GetBytesWithMime(Texture2D texture) | ||
| { | ||
| #if UNITY_EDITOR |
There was a problem hiding this comment.
これもともと Runtime のほうにあったんですね
| /// <param name="bytes"></param> | ||
| /// <param name="texture"></param> | ||
| /// <returns></returns> | ||
| public static bool TryGetBytesWithMime(Texture2D texture, out byte[] bytes, out string mime) |
There was a problem hiding this comment.
これ以上 VrmShaders に実装を委譲するような機能が増えるなら
UniGLTF/Runtime/UniGLTF/IO/TextureIO に interface を定義してそれを実装するようにしたほうがいいかもしれない。
引数増え過ぎちゃうので。
There was a problem hiding this comment.
ベースクラスに対して２方向の拡張があって、
- VRM, VCI など Extensions としての拡張 => 継承とFactory差し替え
- EditorのAsset操作のような拡張 => ExternalObject、Factory差し替え
- 以前は、
#if UNITY_EDITORだったが整理中
- 以前は、
だいぶ集まってきたのでそろそろ interface 等の整理ができるかもしれない。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#758