fix(runtime-core): fix warning for missing event handler #11489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
This reverts commit d465288da200b79c198d5c50a2bf0347c99a36b7.
event handler props can be defined in camel and kebab cases Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Size ReportBundles
Usages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4803
Closes #8268
There is a warning message shown if an emitted event is not declared via
emitsorprops. However, if the event is emitted in kebab-case, the check for a declared prop does not take that into account.The property keys in
propsOptionshave been normalized to camelCase, so the warning needs to usecamelizewhen performing the check.In addition, the warning message should use
camelizewhen suggesting the prop name, so that it matches the usual convention for declaring props.I've included several examples in the Playgrounds below. Some are more realistic than others, but they should all behave correctly with the changes in this PR:
mainThere is an existing PR for this, #8268, but I think there are problems with the changes proposed there. I've used that PR as the basis for this PR.