fix(runtime-core): fix warning for missing event handler #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
This reverts commit d465288da200b79c198d5c50a2bf0347c99a36b7.
event handler props can be defined in camel and kebab cases Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
Comment on lines
+104
to
+105
| `Component emitted event "${event}" but didn't declare a "${toHandlerKey(camelize(event))}" prop ` + | ||
| `or a "${camelize(event)}" emit option.` |
There was a problem hiding this comment.
I understand that this wording came from #4804 (comment), but I think the previous wording (with just the addition of camelize to the prop name) was better. In particular:
- The suggestion to use a prop should come last, as using
emitsis a much more common solution than using a prop. - The suggested name for the
emitsoption in this warning is currently incorrect. e.g. See Playground, which claims thatupdateFooshould be added toemits, even though it is already included. The check forevent in emitsOptionsa few lines up isn't usingcamelize, so the warning needs to be consistent with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4803
is a successor to #4804 due to the original fork not being available anymore