Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler-sfc): support module string names syntax #7428

Merged
merged 3 commits into from
Mar 28, 2023
Merged

feat(compiler-sfc): support module string names syntax #7428

merged 3 commits into from
Mar 28, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Dec 29, 2022 •
edited
Loading

@sxzz sxzz changed the title feat(compiler-sfc): support module string names syntax feat(compiler-sfc/compiler-sfc): support module string names syntax Dec 29, 2022
@sxzz sxzz changed the title feat(compiler-sfc/compiler-sfc): support module string names syntax feat(compiler-sfc/reactivity-transform): support module string names syntax Dec 29, 2022
@netlify
Copy link

netlify bot commented Dec 29, 2022

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit dbf987e
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/63ad99219e957600092c6521

@netlify
Copy link

netlify bot commented Dec 29, 2022

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit dbf987e
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63ad9921aa8019000926ed2f

@netlify
Copy link

netlify bot commented Dec 29, 2022

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 76b8573
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63ad996fc612d70009016e79

@zhangzhonghe
Copy link
Member

zhangzhonghe commented Dec 29, 2022 •
edited
Loading

Demo

This demo has multiple script tags, and it causes the console to get an error.

@sxzz
Copy link
Member Author

sxzz commented Dec 29, 2022

@zhangzhonghe Fixed. Didn't notice that before

@sxzz sxzz force-pushed the fix/import-as-string branch 2 times, most recently from 484bfad to 799029e Compare February 1, 2023 15:11
@yyx990803
Copy link
Member

Closing due to reactivity transform deprecation.

@yyx990803 yyx990803 closed this Mar 28, 2023
@sxzz
Copy link
Member Author

sxzz commented Mar 28, 2023

@yyx990803 Not only for Reactivity Transform, but also apply for SFC file.

@sxzz sxzz changed the title feat(compiler-sfc/reactivity-transform): support module string names syntax feat(compiler-sfc): support module string names syntax Mar 28, 2023
@sxzz sxzz reopened this Mar 28, 2023
@yyx990803 yyx990803 merged commit 0002567 into main Mar 28, 2023
@yyx990803 yyx990803 deleted the fix/import-as-string branch March 28, 2023 08:28
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
@sxzz @IAmSSH
feat(compiler-sfc): support module string names syntax (vuejs#7428)
c587bee 
tc39/ecma262#2154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sxzz @zhangzhonghe @yyx990803 @edison1105