fix(hydration): force patch dynamic props when hydrating #9083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
…Hydrate # Conflicts: # packages/runtime-core/__tests__/hydration.spec.ts # packages/runtime-core/src/hydration.ts
…Hydrate # Conflicts: # packages/runtime-core/__tests__/hydration.spec.ts # packages/runtime-core/src/hydration.ts
|
up |
…psHydrate # Conflicts: # packages/runtime-core/__tests__/hydration.spec.ts
|
|
||
| // #9033 | ||
| test('force patch dynamic props when hydrating', () => { | ||
| const timestamp = Date.now() |
There was a problem hiding this comment.
Is there a reason why this test needs to use Date.now()? It may be more 'real', but it also makes the test less reliable. The two calls to Date.now() might yield the same number, or they might not. Couldn't the same functionality be tested using fixed values instead?
There was a problem hiding this comment.
I have no problem with using Date.now(), but it makes more sense to use a fixed value.
edison1105
added
🐞 bug
…psHydrate # Conflicts: # packages/runtime-core/__tests__/hydration.spec.ts # packages/runtime-core/src/hydration.ts
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-dom
@vue/runtime-core
@vue/shared
@vue/server-renderer
@vue/compat
vue
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #9033
The same code is executed on the client and the server, but some dynamic props may be inconsistent between the two runs (such as timestamps)， I think they should always be consistent with the client