-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hydration): force patch dynamic props when hydrating #9083
Open
baiwusanyu-c
wants to merge
8
commits into
vuejs:main
Choose a base branch
from
baiwusanyu-c:bwsy/fix/dynamicPropsHydrate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c0986d7
fix(hydration): force patch dynamic props when hydrating
baiwusanyu-c 5b1b115
Merge branch 'main' into bwsy/fix/dynamicPropsHydrate
baiwusanyu-c 1f5b562
Merge remote-tracking branch 'origin/main' into bwsy/fix/dynamicProps…
baiwusanyu-c 9613bcc
Merge branch 'main' into bwsy/fix/dynamicPropsHydrate
baiwusanyu-c a0ff004
Merge remote-tracking branch 'origin/main' into bwsy/fix/dynamicProps…
baiwusanyu-c a9cc99f
[autofix.ci] apply automated fixes
autofix-ci[bot] 0e4cfb4
Merge remote-tracking branch 'upstream/main' into bwsy/fix/dynamicPro…
baiwusanyu-c 227eaf1
Merge remote-tracking branch 'upstream/main' into bwsy/fix/dynamicPro…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this test needs to use
Date.now()
? It may be more 'real', but it also makes the test less reliable. The two calls toDate.now()
might yield the same number, or they might not. Couldn't the same functionality be tested using fixed values instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem with using
Date.now()
, but it makes more sense to use a fixed value.