-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose @volar/server/out/index.js as executable in $NPM_PREFIX/bin #458
Comments
I'm not sure if Whatever is more aesthetically pleasing to you all :P May be worth considering |
I decide use |
Sorry for my late reply. 7734d1e looks fine. |
I think it's confusing with vetur, whose command is |
It's no problem I think. 🤔 |
Change command |
I confirmed it works fine with vim-lsp and sent PR to vim-lsp-settings with it ( mattn/vim-lsp-settings#458 ). |
Please note #876. :) |
I was trying to add Volar as a language server for nvim-lspconfig and I got hung up for a second on the part where you need to tell neovim which executable to launch. I later figured it out and this issue is a nitpick, but still it removes a tiny hurdle.
After you run
npm i -g @volar/server
there's no binary added to the NPM bin/ folder, so you can't easily launch it. On the other hand with Vetur's language server, after global install you have thevuels
command.The Vim LSP integrations for Volar work around this by creating wrapper scripts. They just execute the server/out/index.js with Node and passthrough any arguments.
Examples:
https://github.com/ouuan/AUR-packages/blob/master/volar-server/wrapper.sh
https://github.com/mattn/vim-lsp-settings/blob/1fdda7d3493f086b5e28446f8daa6a9d6dc1325c/installer/install-volar.sh#L16
I'm not familiar with are the executable files created but Vetur's LS has this: https://github.com/vuejs/vetur/blob/master/server/package.json#L9
Basically, the intended effect is that you can run
volar-server
from the command line after runningnpm i -g @volar/server
. Which is not possible now.The text was updated successfully, but these errors were encountered: