Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @volar/server package name and cli command #876

Closed
johnsoncodehk opened this issue Jan 19, 2022 · 3 comments · Fixed by #1021
Closed

Rename @volar/server package name and cli command #876

johnsoncodehk opened this issue Jan 19, 2022 · 3 comments · Fixed by #1021
Labels
enhancement New feature or request

Comments

@johnsoncodehk
Copy link
Member

As a part of refactor tasks, I'm planing rename @volar/server to @volar/vue-language-server, and change cli command from volar-server to vue-language-server.

Considering this has some impact on other IDE tools, I'll keep this issue for a while.
@johnsoncodehk johnsoncodehk mentioned this issue Jan 19, 2022
Closed
@johnsoncodehk johnsoncodehk pinned this issue Jan 22, 2022
@johnsoncodehk johnsoncodehk unpinned this issue Jan 26, 2022
@johnsoncodehk johnsoncodehk pinned this issue Mar 10, 2022
@johnsoncodehk johnsoncodehk added enhancement New feature or request and removed in-discuss labels Mar 10, 2022
@johnsoncodehk johnsoncodehk mentioned this issue Mar 10, 2022
Merged
This was referenced Mar 11, 2022
Merged
Merged
mjlbach pushed a commit to neovim/nvim-lspconfig that referenced this issue Mar 13, 2022
@sethidden
chore(volar): @volar/server -> @volar/vue-language-server (#1770)
8ed845d 
See vuejs/language-tools#876

Add new languageFeatures.implementation = true option
as per CHANGELOG.md in volar repo for version 0.33
@williamboman
Copy link

Hey! I think it'd be neat if the old executable had remained (but been deprecated), to allow room for tooling to update without breaking!

williamboman pushed a commit to williamboman/nvim-lsp-installer that referenced this issue Mar 14, 2022
@sethidden
chore(volar): update volar package name (#534)
e244ac1 
see vuejs/language-tools#876
see https://github.com/johnsoncodehk/volar/blob/master/packages/vue-language-server/package.json#L2
@johnsoncodehk
Copy link
Member Author

Hi @williamboman, due to pkg name have been changed, I think if we still keep volar-server bin file in @volar/vue-language-server will make some confusion, because we can't know it actually mean to @volar/server or @volar/vue-language-server.

@williamboman
Copy link

Ah, that's a good point. I didn't consider that the package name was changed.

@johnsoncodehk johnsoncodehk unpinned this issue Mar 25, 2022
@johnsoncodehk johnsoncodehk mentioned this issue Apr 26, 2022
Merged
BBOOXX added a commit to BBOOXX/ale that referenced this issue Sep 10, 2022
@BBOOXX
chore(volar): update volar executable name
d1e0732 
see: vuejs/language-tools#876
see: johnsoncodehk/volar/blob/master/packages/vue-language-server/package.json#L11
@BBOOXX BBOOXX mentioned this issue Sep 10, 2022
Merged
BBOOXX added a commit to BBOOXX/ale that referenced this issue Sep 10, 2022
@BBOOXX
chore(volar): update volar executable name
b7c47fc 
see: vuejs/language-tools#876
see: johnsoncodehk/volar/blob/master/packages/vue-language-server/package.json#L11
hsanson pushed a commit to dense-analysis/ale that referenced this issue Sep 11, 2022
@BBOOXX
chore(volar): update volar executable name (#4308)
77fcf9b 
see: vuejs/language-tools#876
see: johnsoncodehk/volar/blob/master/packages/vue-language-server/package.json#L11
mnikulin pushed a commit to mnikulin/ale that referenced this issue Nov 12, 2023
@BBOOXX @mnikulin
chore(volar): update volar executable name (dense-analysis#4308)
b6c9e0a 
see: vuejs/language-tools#876
see: johnsoncodehk/volar/blob/master/packages/vue-language-server/package.json#L11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: @volar/server -> @volar/vue-language-server vuejs/language-tools
2 participants
@williamboman @johnsoncodehk