Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[venom]: remove some dead code in venom_to_assembly #4042

Merged
merged 3 commits into from
May 22, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 21, 2024

What I did

How I did it

How to verify it

Commit message

remove some dead code in `venom_to_assembly`

`lt` and `gt` are one_to_one opcodes so they can reuse that logic.

`ceil32` is already converted in `ir_node_to_venom`

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

lt and gt are one_to_one opcodes so they can reuse that logic.

ceil32 is already converted in ir_node_to_venom
@charles-cooper charles-cooper changed the title remove some dead code in venom_to_assembly fix[venom]: remove some dead code in venom_to_assembly May 21, 2024
@charles-cooper charles-cooper marked this pull request as ready for review May 22, 2024 11:15
@charles-cooper charles-cooper enabled auto-merge (squash) May 22, 2024 11:16
@charles-cooper charles-cooper merged commit f0afaf0 into vyperlang:master May 22, 2024
156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants