Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[venom]: remove some dead code in venom_to_assembly #4042

Merged
merged 3 commits into from
May 22, 2024
Merged

fix[venom]: remove some dead code in venom_to_assembly #4042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f24941
remove some dead code in venom_to_assembly
charles-cooper May 21, 2024
58c4800
Merge branch 'master' into fix/venom-asm
charles-cooper May 21, 2024
d32637f
Merge branch 'master' into fix/venom-asm
charles-cooper May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions vyper/venom/venom_to_assembly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
"eq",
"iszero",
"not",
"lg",
"lt",
"gt",
"slt",
"sgt",
"create",
Expand Down Expand Up @@ -454,10 +454,6 @@ def _generate_evm_for_instruction(
inst.operands[0], IRVariable
), f"Expected IRVariable, got {inst.operands[0]}"
assembly.append("JUMP")
elif opcode == "gt":
assembly.append("GT")
elif opcode == "lt":
assembly.append("LT")
elif opcode == "invoke":
target = inst.operands[0]
assert isinstance(
Expand Down Expand Up @@ -495,8 +491,6 @@ def _generate_evm_for_instruction(
"SHA3",
]
)
elif opcode == "ceil32":
assembly.extend([*PUSH(31), "ADD", *PUSH(31), "NOT", "AND"])
elif opcode == "assert":
assembly.extend(["ISZERO", "_sym___revert", "JUMPI"])
elif opcode == "assert_unreachable":
Expand Down
Loading