-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify description computation for aria-describedby #177
Conversation
I suspect your change is wrong and has nothing to do with what was discussed:
|
I understand now. 🤦🏻♂️ Thank you for setting me straight, @JAWS-test. This is particularly embarrassing because I scribed that Nov 10 meeting. My brain was apparently not in attendance. Assuming that I do actually understand now 😅, it seems like this simple replacement of “Text content computation” with the more specific “Name computation” would be sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this also need to be changed in item 3 (Host language features) where the phrase "text equivalent computation" is used? It's not clear to me why this one would be specific to name comp, but the latter references T.E. comp.
(E.g. line 247, just below this diff boundary) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the answer is yes, so I'm changing my response from "Comment" to "Request Changes."
Done. Thanks, @cookiecrook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi, I've been rereading this issue and am confused because it seems to flip back and forth. Is the purpose to prevent self-referencing by aria-describedby but not for aria-labelledby? I have seen this used successfully on tables that have checkbox or radio button controls that will reference the parent row using aria-describedby to announce the full content of the row being selected when the screen reader is interacting with it, and this is quite helpful. Would this change prevent something like this from working? |
@accdc wrote:
If you're referring to the note @jnurthen and I were discussing in the thread, no, it won't prevent anything from working. It's just informative authoring guidance. If "this change" is referring to something else, I would need a more specific reference. |
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
I’m inclined to limit this PR to clarifying that In the meantime, I’ve committed your suggested reversion, @cookiecrook. I also created a quick Codepen to examine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me
Thanks very much, @cookiecrook. I believe this is ready for merge, @spectranaut / @jnurthen / @pkra? |
SHA: 881d960 Reason: push, by MelSumner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #176.
Added editorial notes to 4.2 Description Computation.
Preview | Diff