fix: Correct sorting for the tester assignment menu, addresses #993 (#…

…1067) * Fix tester menu sorting * Use localeCompare * Sort initial tester assign dropdown * Remove debugging code --------- Co-authored-by: Howard Edwards <howarde.edwards@gmail.com> Co-authored-by: alflennik <alflennik@users.noreply.github.com>
w3c · May 6, 2024 · 01c818f · 01c818f
1 parent b8cefcd
commit 01c818f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/client/components/TestQueue/index.jsx b/client/components/TestQueue/index.jsx
@@ -114,7 +114,9 @@ const TestQueue = () => {
                                 <TestQueueRow
                                     key={key}
                                     user={auth}
-                                    testers={testers}
+                                    testers={testers.sort((a, b) =>
+                                        a.username.localeCompare(b.username)
+                                    )}
                                     testPlanReportData={testPlanReport}
                                     latestTestPlanVersions={
                                         latestTestPlanVersions

diff --git a/client/components/TestQueueRow/index.jsx b/client/components/TestQueueRow/index.jsx
@@ -241,7 +241,7 @@ const TestQueueRow = ({
                     {draftTestPlanRuns
                         .slice() // because array was frozen
                         .sort((a, b) =>
-                            a.tester.username < b.tester.username ? -1 : 1
+                            a.tester.username.localeCompare(b.tester.username)
                         )
                         .map(({ tester }) => {
                             return (