Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sorting for the tester assignment menu #1067

Merged
merged 6 commits into from
May 6, 2024

Conversation

Paul-Clue
Copy link
Collaborator

see issue #993

This pull request correctly sorts the tester names in the dropdown for assigning testers and the dropdown for running a test as specific tester.

@Paul-Clue Paul-Clue requested a review from alflennik May 1, 2024 00:34
@@ -48,6 +48,7 @@ const TestQueue = () => {
testPlanReports = [],
testPlans = []
} = data;
// section:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and removed it

@alflennik alflennik merged commit 01c818f into development May 6, 2024
2 checks passed
@alflennik alflennik deleted the tester-assign-menu-sorting branch May 6, 2024 19:08
@howard-e howard-e mentioned this pull request May 28, 2024
howard-e added a commit that referenced this pull request May 28, 2024
Issues addressed:
* #1105, addresses w3c/aria-at#1070
* #1053, addresses w3c/aria-practices#2971
* #1097, addresses #977
* #1095, addresses #991
* #1093, addresses #934
* #1000, addresses #818
* #1089, addresses #992
* #1067, addresses #993
* #1056, addresses w3c/wai-aria-practices#212

---------

Co-authored-by: alflennik <alflennik@users.noreply.github.com>
Co-authored-by: Paul Clue <67766160+Paul-Clue@users.noreply.github.com>
Co-authored-by: Mx Corey Frang <corey@bocoup.com>
Co-authored-by: Mx. Corey Frang <gnarf37@gmail.com>
Co-authored-by: Erika Miguel <erika@bocoup.com>
Co-authored-by: Mike Pennisi <mike@mikepennisi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants