Redesign support table warning #1056
Conversation
There was a problem hiding this comment.
Great work, @Paul-Clue! I have some requests in the comments.
| @@ -9,7 +9,7 @@ | |||
| {{#unless dataEmpty}} | |||
| {{#if (isCandidate phase)}} | |||
| <details id="embed-report-phase-container"> | |||
| <summary id="candidate-title"><span>Warning! Unapproved Report</span></summary> | |||
| <summary id="candidate-title"><span><span>Warning! Unapproved Report</span></span></summary> | |||
There was a problem hiding this comment.
I think this could be improved semantically with a heading and a span instead of two spans.
There was a problem hiding this comment.
This has been taken care of.
| --left-right-padding: 55px; | ||
| } | ||
|
|
||
| #candidate-title > * { |
There was a problem hiding this comment.
I think instead of applying this to all the children, make this individual margin left and right on the span and icon. I also think that the space between the icon and span can be smaller.
There was a problem hiding this comment.
This has been taken care of.
| @@ -9,7 +9,7 @@ | |||
| {{#unless dataEmpty}} | |||
| {{#if (isCandidate phase)}} | |||
| <details id="embed-report-phase-container"> | |||
| <summary id="candidate-title"><span>Warning! Unapproved Report</span></summary> | |||
| <summary id="candidate-title"><span><h1>Warning! Unapproved Report</h1></span></summary> | |||
There was a problem hiding this comment.
Could we make this an h4 so it matches the flow of headings in the APG website?
There was a problem hiding this comment.
This has been taken care of.
|
Code-wise it looks great. It's great to be able to use the exact same styling in both places. However there are some differences still. Take a look at the screenshot. 
I think we are not currently using the same font, font-size and the border width looks different. Also I'm not 100% convinced by the pill-shaped background on the h4, something feels off about it and I feel like something more similar to the other disclosure might be preferable. |
Issues addressed: * #1105, addresses w3c/aria-at#1070 * #1053, addresses w3c/aria-practices#2971 * #1097, addresses #977 * #1095, addresses #991 * #1093, addresses #934 * #1000, addresses #818 * #1089, addresses #992 * #1067, addresses #993 * #1056, addresses w3c/wai-aria-practices#212 --------- Co-authored-by: alflennik <alflennik@users.noreply.github.com> Co-authored-by: Paul Clue <67766160+Paul-Clue@users.noreply.github.com> Co-authored-by: Mx Corey Frang <corey@bocoup.com> Co-authored-by: Mx. Corey Frang <gnarf37@gmail.com> Co-authored-by: Erika Miguel <erika@bocoup.com> Co-authored-by: Mike Pennisi <mike@mikepennisi.com>
see issue #212 (in wai-aria-practices)
This pull request changes the warning at the top of the APG support table so that it matches the style of the warnings on the rest of the page.