Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude 0-level priority assertions in the collection form #1012

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Dec 5, 2023

Preview Tests

See #1008.

To test this change:

  • Run npm run make-v2 <pattern>
  • Update any of the created *-commands.csv's row value for the "assertionExceptions" column with 0:<assertionId> ...
    • Note: assertionId must match a defined assertionId of a row in the generated assertions.csv
    • Note: tests.csv must include the assertion id in a row's "assertions" column
  • Run npm run build
  • Observe that the assertion is excluded on <baseurl>/review/<pattern>.html under the expected command (this was included before this PR)
  • Select an AT link under tests and observe that the assertion is excluded on <baseurl>/tests/<pattern>/<testfile_name>.html under the expected command

Note that #1014 has also been submitted to make previewing those changes easier (check description for changes and preview link)

@howard-e howard-e requested review from mcking65 and stalgiag December 5, 2023 19:40
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify that excluded assertions do not appear. Code looks good.

Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and I was able to exclude assertions. I didn't notice any issues with the code.

@stalgiag stalgiag merged commit 6a41186 into master Feb 5, 2024
7 checks passed
@stalgiag stalgiag deleted the collection-0-priority-support branch February 5, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants