Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collection form to be consistent with updated review pages #1017

Merged
merged 15 commits into from
May 29, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Dec 12, 2023

Preview Tests

See #1009 and #1010.

This PR updates the collection form's content to align with a subset of recent changes on the review page, introduced by #997.

Note: These changes are branched off of #1012. That PR should be merged before these changes.

@howard-e howard-e changed the base branch from master to collection-0-priority-support December 12, 2023 20:25
@howard-e howard-e changed the base branch from collection-0-priority-support to master December 12, 2023 20:26
@howard-e howard-e force-pushed the update-collection-form branch from eb1f1d1 to 6ec9157 Compare December 12, 2023 20:27
@howard-e howard-e changed the base branch from master to collection-0-priority-support December 12, 2023 20:28
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I reviewed the preview and I can verify that the collection form now matches what I'm seeing on the latest aria-at-app versions. Code looks good. I have a couple of questions but in general it's looking great.

tests/resources/aria-at-harness.mjs Outdated Show resolved Hide resolved
tests/resources/aria-at-test-run.mjs Show resolved Hide resolved
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing that feedback!

Base automatically changed from collection-0-priority-support to master February 5, 2024 22:45
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at many of these files in a long time (or ever) so it took me a while to parse what was going on. The code in many of these files feels quite complex due to inline transformation of data to match specific input/output schemas. That said, I think what you have changed here does simplify some of this logic in places which is quite a feat and hopefully part of a gradually move towards simplification and separation of concerns. Most importantly, it does it what it sets out to do (as far as my testing was able to tell)

There is a small merge conflict that needs to be resolved but otherwise I believe this is safe too merge. I am going to approv and hand it back to you for resolving that conflict.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @howard-e !

@howard-e howard-e merged commit 54c977a into master May 29, 2024
8 checks passed
@howard-e howard-e deleted the update-collection-form branch May 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants