Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox Pattern and Examples: Convert to support draft ARIA 1.2 specification #1255

Merged
merged 54 commits into from
Nov 15, 2019
Merged

Combobox Pattern and Examples: Convert to support draft ARIA 1.2 specification #1255

Show file tree
Hide file tree
Changes from 43 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
a842b94
Initial draft of 1.2 proposal
mcking65 Sep 9, 2019
92d529b
Update documentation for aria-controls
mcking65 Sep 9, 2019
e33a189
Remove references to ArIA 1.0 pattern
mcking65 Sep 9, 2019
c7c77c1
Move 1.0 examples to root and delete 1.0 and 1.1 directories
mcking65 Nov 8, 2019
7d5c0c5
Update list of examples
mcking65 Nov 8, 2019
93be0a9
Change 1.1 to 1.2 in title and footer of autocomplete-list example page
mcking65 Nov 8, 2019
c0634d9
Update paths in and revise text of combobox-autocomplete-both.html
mcking65 Nov 9, 2019
cc9c10f
Add similar examples list back to the autocomplete-list example
mcking65 Nov 9, 2019
dfefb81
Update paths and text for combobox-autocomplete-none.html
mcking65 Nov 10, 2019
252768b
added grid combobox example to branch
jongund Nov 10, 2019
673d6ab
added grid combobox example to branch
jongund Nov 10, 2019
34e1afc
updated regression tests for updated autocomplete both, list and none…
jongund Nov 11, 2019
4057291
Remove ARIA 1.2 from grid combo title and change version in title tag…
mcking65 Nov 11, 2019
4787873
Update list of similar examples and fix design pattern URI
mcking65 Nov 11, 2019
5cf2c0e
Fix URIs for main doc in keyboard section
mcking65 Nov 11, 2019
d0187c3
Editorial revisions to states and props table in grid combo page
mcking65 Nov 11, 2019
e7369da
Update footer nav link in grid combo page
mcking65 Nov 11, 2019
a5b491e
Update combobox pattern per 1.2
zcorpan Nov 11, 2019
4678982
Add a note about aria-owns
zcorpan Nov 11, 2019
aa08d15
Note in the intro that combobox can be editable or non-editable
zcorpan Nov 11, 2019
68d07ae
Tweak text that compare combobox to listbox and menu buttons
zcorpan Nov 11, 2019
976996e
Try describing comboboxes aseither editable or select-only, to avoid …
mcking65 Nov 11, 2019
54e1a28
Additional editorial revisions to combobox pattern description
mcking65 Nov 12, 2019
e79a813
Add 'editable' to example titles
mcking65 Nov 12, 2019
5455675
Revise combobox pattern keyboard interactions to describe select-only…
mcking65 Nov 12, 2019
1587eeb
Revise pattern listbox keyboard interactions to more clearly reflect …
mcking65 Nov 12, 2019
fc2add9
Editorial revisions to pattern grid keyboard interaction
mcking65 Nov 12, 2019
529c522
editorial revisions to pattern introduction
mcking65 Nov 12, 2019
3987903
Editorial revisions to tree keyboard interaction in the pattern.
mcking65 Nov 12, 2019
a9bad46
Rename Combo Box to Combobox for consistency
zcorpan Nov 12, 2019
cd492e7
Change spelling of pop-up to popup for consistency
zcorpan Nov 12, 2019
09f6496
Prefer <label> when possible
zcorpan Nov 12, 2019
3db149c
Fix eslint errors in combobox example
zcorpan Nov 12, 2019
b8efc3f
aria-controls should always be set, not just when the popup is visible
zcorpan Nov 12, 2019
36ccb4b
Fix note markup in keyboard interaction section for the combobox in t…
mcking65 Nov 12, 2019
4206c94
In combobox pattern keyboard interaction for combobox, clarify enter …
mcking65 Nov 12, 2019
267e816
Pattern keyboard interaction for combobox: change moves selection to …
mcking65 Nov 12, 2019
51653ae
updated regression tests for grid combobox
jongund Nov 12, 2019
feb730e
Pattern keyboard interaction section for tree: fix note about aria-or…
mcking65 Nov 12, 2019
2b14de2
Editorial revisions to states and properties in the pattern
mcking65 Nov 12, 2019
acc2c68
This file is no longer needed, since example has been deleted
jongund Nov 12, 2019
ffa2f7c
Pattern introduction: revise comparison to listbox and menu button to…
mcking65 Nov 12, 2019
280b678
Fix broken (and ignored) autocomplete-both test
Nov 13, 2019
439f65d
Apply editorial changes to pattern suggested by @carmacleod and @char…
mcking65 Nov 14, 2019
83f5ff6
Revise trigger conditions list per Carolyn's suggestion
mcking65 Nov 14, 2019
4a9d3ea
Apply 3 more editorial changes to pattern suggested by @carmacleod.
mcking65 Nov 14, 2019
a10305a
Fix white space in structural roles section (unrelated to PR)
mcking65 Nov 14, 2019
dd6f6c0
Remove aria-multiline guidance from states and props section of pattern
mcking65 Nov 14, 2019
e51ad04
Remove aria-haspopup from examples where it is not necessary
mcking65 Nov 14, 2019
73ca367
Fix visual design issues with combobox examples 1-3
zcorpan Nov 14, 2019
d2f0e5a
Tweak styles of combobox examples 1-3 to look nicer
zcorpan Nov 14, 2019
ccd56b7
fix constant option remove/append bug, fix label styling
smhigley Nov 14, 2019
312ba70
Remove tests for aria-haspopup on listbox examples
Nov 14, 2019
f535354
Fix stylelint config to correctly ignore only forced-colors media fea…
zcorpan Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
314 changes: 162 additions & 152 deletions aria-practices.html
View file
Open in desktop

Large diffs are not rendered by default.

Binary file removed examples/combobox/aria1.1pattern/imgs/arrow_drop_down_grey_27x27.png
View file
Open in desktop
Binary file not shown.
139 changes: 0 additions & 139 deletions examples/combobox/aria1.1pattern/js/listbox-combo-example.js
View file
Open in desktop

This file was deleted.

259 changes: 0 additions & 259 deletions examples/combobox/aria1.1pattern/js/listbox-combobox.js
View file
Open in desktop

This file was deleted.

Loading