-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider: Media Seek Slider example #1863
Conversation
NVDA/Chrome in browse mode:
|
@shirsha |
@jongund This is also looking good. On a previous pull request (which I think also had a volume slider), I mentioned that "Media Seek" is unnecessarily long as the label for the slider; the context of media playback is already obvious/implied. Any thoughts on changing it to just "Seek"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and test review are good. :)
… on other slider example pages
…ing in other examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final edits done to copy; This is an approving editorial review.
The example looks good. |
@shirsha commented:
Thank you Siri. Now, could you please start a review from the files page of the PR, write that you reviewed accessibility on Windows, and check the approve option?
Since that happens only for the static labels on the time markers and not for the actual value, I don't think there is an issue with understandability. That said, this highlights a gap in ARIA, not a problem with the example. I am not aware of anyway to declare those strings as representing elapsed time rather than time of day. I think this is a good example of a scenario where it would not be a good idea to put the burden of deciding what screen readers should say on content authors. Generally, we shouldn't encourage authors to fix every possible mispronunciation by force-feeding specific speech. Instead, content authors should be able to declare the semantics of the element and then let screen readers decide what to say. Since we don't have a way to tell screen readers what kind of elements those strings represent, voice synthesizers guess. |
@carmacleod @smhigley |
Updated discussion on the media seek slider example on May 25 meeting minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
On macOS with VoiceOver the slider mostly works and the |
@a11ydoer @mcking65 |
I have created a new media seek example based on the discussion at the 20 April 2021 meeting to include the only the media seek slider to illustrate the use of
aria-valuetext
.Features:
aria-valuetext
on focus, but not on change in value.event.key
none
role on SVG elementforced-color-adjust
toauto
on the SVG elements.stroke-opacity
andfill-opacity
instead oftransparent
values for setting stroke and fill colors for the SVGrect
used for focus ring for high contrast mode.Preview media seek slider example
Review checklist
Preview | Diff