-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated slider examples using aria-valuetext based on 6 April 2021 meeting #1857
Conversation
@jongund Thanks for your work on this! Some initial thoughts:
|
@jscholes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visuals & approach look good to me!
* Desc: Slider widget that implements ARIA Authoring Practices | ||
*/ | ||
|
||
class SliderSeek { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest splitting each class to its own JS file, just to make them easier to find and read, but since it's already been suggested that we only have one example per page, that's probably happening anyway.
Thanks, @jongund ! |
I have created a new example based on the discussion at the 6 April 2021 meeting to include the temperature slider, remove fan speed slider and a new media seek slider to illustrate the use of
aria-valuetext
.Features.Changes:
event.keyCode
presentation
role on SVG elementforced-color-adjust
toauto
on the SVG elements.stroke-opacity
andfill-opacity
instead oftransparent
values for setting stroke and fill colors for the SVGrect
used for focus ring for high contrast mode.Preview media seek slider example
Review checklist
Preview | Diff