-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider: Temperature Selector Slider Example #1864
Conversation
The meaning of this is not clear to me:
What problem does this solve for people with visual impairments in particular? |
In valuetext, I wonder if using the degrees symbol instead of writing out the word "degrees" could impact announcement with some screen readers. We advise content designers to avoid using symbols in label strings at Facebook. However, the driver there might be translation. I'm not sure if there is generally accepted best practice around that. Similarly, I am wondering if we want to use the letter "C" or write out celsius. |
@mcking65 |
@mcking65 |
I think I now understand the meaning of:
However, that does not make it clear that the value display moves with the thumb. Is the following revision accurate?
|
@jongund
The grammar is not correct. But, I can't correct it because I don't know what it means. Who would need to adjust the opacity instead of using the transparent value? The author? Does our example adjust opacity or use the transparent value? |
</section> | ||
|
||
<section> | ||
<h2 id="kbd_label" style="clear: both;">Keyboard Support</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the styling on this heading do? We don't have it on the kb heading in other examples? Should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcking65
I think some older examples may use the CSS float
property, so this is probably a ruminant from some of those early examples to make sure the heading was on a new line. It can be removed.
@mcking65 |
Thank you for the help with the HCM documentation. I revised the focus ring sentences slightly to try to simplify and clarify a bit more. Here is where I landed. Is this wording clear and accurate?
|
@mcking65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial revisions and review complete. Looking great! Thank you, thank you @jongund for the fabulous work on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to zoom in the example to activate and interact with slider thumb. Once I activate it, I could adjust the temperature. The exisiting problem is that the change is still annoucned as percentage, not as celsius degree. I have attached two screen shots, one is 22.4 celsicus as 44 percent, the other one is 34.1 celsius as 84 percent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. There are still a few test failures but they're unrelated to this PR and are part of another effort to get APG into a "green" state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions appropriately with Firefox/Chrome and NVDA/JAWS latest. HCM Black and White look good. Rock on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visual design looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an approving Accessibility Review for VO + Safari/Chrome on macOS
Fn+up/down arrows work for PageUp/PageDown in VoiceOver the same as with VO off (i.e. temperature goes up/down by 2 degrees instead of 1/10 degree). (Also works with PageUp/PageDown using a Windows keyboard).
Fn+left/right arrows for Home/End work oddly in VoiceOver: they do change the slider value to min/max as expected, but then they move the VO cursor to unexpected locations at the beginning and end of the Thermostat group. This seems like a VO bug and not anything in the example code. (Also tried Home/End using a Windows keyboard, with the same odd results).
So, other than the weirdness with Home/End, this example works well with VoiceOver on macOS.
I have created a new temperature selector example based on the discussion at the 20 April 2021 meeting to include the only the temperature selector slider to illustrate the use of
aria-valuetext
andaria-orientation
.Features:
aria-valuetext
.event.key
none
role on SVG elementforced-color-adjust
toauto
on the SVG elements.stroke-opacity
andfill-opacity
instead oftransparent
values for setting stroke and fill colors for the SVGrect
used for focus ring for high contrast mode.Preview temperature slider example
Review checklist
Preview | Diff