-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARIA: Editorial cleanup needed to "Presentational Roles Conflict Reso… #852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment please.
@joanmarie Here's a preview link to the Presentational Roles Conflict Resolution section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments for proposed changes.
approved the changes per my comments, but +1 to @joanmarie's comments |
- remove understandable - remove "user agent MAY resort to an internal recovery mechanism"
Hi, @mcking65! This PR is ready for review. Note that the Diff is messy because I reorganized words and moved things into a bulleted list. I only changed the prose in the Presentational Roles Conflict Resolution section (nothing else), so there's only 3 paragraphs plus the example to review (the bulleted list is in paragraph 2). Note that the phrase "or otherwise interactive" is still being discussed in #1192, so for now, I think we should just keep that phrase as-is in order to get this PR merged sooner. |
The example helps a lot, but I am concerned about an example that goes against APG guidance. We caution against using aria-label on a heading. |
add "with its implicit role" for clarity
@mcking65 Notes for the latest commit:
|
@jnurthen Example is fixed up. Here's the ping you requested. :) |
#852) * ARIA: Editorial cleanup needed to "Presentational Roles Conflict Resolution" section #646 * - remove references to accessibility API mappings - remove understandable - remove "user agent MAY resort to an internal recovery mechanism" * Make "User agents" the subject of the MUST NOT. * Remove "host language" and link "elements" to definition * use aria-describedby on h1 instead of aria-label add "with its implicit role" for clarity
#852) * ARIA: Editorial cleanup needed to "Presentational Roles Conflict Resolution" section #646 * - remove references to accessibility API mappings - remove understandable - remove "user agent MAY resort to an internal recovery mechanism" * Make "User agents" the subject of the MUST NOT. * Remove "host language" and link "elements" to definition * use aria-describedby on h1 instead of aria-label add "with its implicit role" for clarity
…lution" section #646
Please see #646 (comment) for reviewing suggestion.
Resolves #646.
Preview | Diff