Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial?: Fix for #759 #885

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Editorial?: Fix for #759 #885

merged 3 commits into from
Jan 15, 2019

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Jan 11, 2019

Copy link
Contributor

@joanmarie joanmarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't think that it's necessary to specify it includes the inherited role of presentation, I'm ok with that and believe that is indeed an editorial change.

I'm afraid I'm not cool with the "use its own heuristics" bit, however. We've already dealt with how presentational descendants which remain in the accessibility tree should be mapped in the Core-AAM. See the mappings for presentation and none. As you'll see in those mappings, the Core-AAM specifies what each platform expects. And, yes, those mappings are generic in nature, but they are specific in their expectations for each platform.

That said, arguably it's not sufficient to just remove your proposed change regarding heuristics, because the ARIA spec isn't right in its current form: The reason we made the aforementioned change to the Core AAM is because we didn't want what's currently described in the ARIA spec ("exposes the element according to its implicit native semantics") to happen. At least not in the case of required children. An accessible list item that is not inside an accessible list makes no sense. Ditto for table rows and table cells that are not in tables, which seems to be what is being reported in the original bug.

The current language states:

the user agent ignores the presentation role and exposes the element according to its implicit native semantics.

What about replacing that with something like:

the user agent exposes the element as described in the accessibility API
mappings for presentational objects which remain in the accessibility tree.

?

@joanmarie joanmarie merged commit 2a72f09 into master Jan 15, 2019
joanmarie pushed a commit that referenced this pull request Jan 15, 2019
Clarify if an author applies an ARIA global attribute on an element
with an inherited role of presentation, the user agent should expose
the element to the accessibility tree.
@joanmarie joanmarie deleted the Issue759 branch January 15, 2019 18:48
carmacleod added a commit that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants